-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed shared labels in do loops #43
base: master
Are you sure you want to change the base?
Conversation
Fixes warnings from grd/grdcomp like ``` Fortran 2018 deleted feature: Shared DO termination label 2208 at (1) ```
This is probably the same error that raises warnings in the other packages as well? E.g. the warnings raised during the automated checks for com/comutil, svr/daspk, svr/nksol, svr/vodpk, svr/daux1, api/fmombal, and api/inelrates. Would it be straightforward to apply the same fix to the other packages too? |
@holm10 Yes I think most of the warnings are related to shared labels on nested DO loops
should be replaced by something like
I started with |
Thanks, @bendudson. I suggest to fix them all in this PR, I could give it a go myself later this week. We'll have to run #44 by @trognlien, I'd say. |
Still need to address: - Arithmetic IF-statements - Replace ASSIGN statements - Assigned GOTO-statement
@bendudson I fixed the simple warnings associated with the DO-loops. Plenty of places that don't raise warnings where the labels could be replaced. Compiler still throws a bunch of errors for comutil: mostly some very nasty logical loops using arithmetic IF statements (and deprecated ASSIGN calls). It'd be nice to fix all of these at some point, but I'm ot sure what it would take to assert that the rewrite is logically equivalent... |
Fixes warnings from grd/grdcomp like